New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore `roc build --no-link` pipeline #7236

Merged

smores56 merged 1 commit into main from fix-no-link

Nov 21, 2024

Collaborator

lukewilliamboswell commented Nov 21, 2024

This PR restores the functionality to build a roc app into an object file without a host gives an error Legacy linking failed.

 $ roc build --no-link --emit-llvm-ir examples/simple.roc
Legacy linking failed: Failed to find any legacy linking files; I need one of these three paths to exist:
    examples/../platform/macos-arm64.a
    examples/../platform/macos-arm64.o
    examples/../platform/libhost.a

This was likely broken in #6859, here is the previous implementation that provided this functionality.

// We don't need to spawn a rebuild thread when using a prebuilt host.
     let rebuild_thread = if matches!(link_type, LinkType::Dylib | LinkType::None) {
         None
     } else if is_platform_prebuilt {
// <---snipped--->


          restore --no-link build pipeline

34f5b61

smores56 approved these changes

View reviewed changes

smores56 merged commit 6a3db1e into main

19 checks passed

smores56 deleted the fix-no-link branch

November 21, 2024 09:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet